Adding log binning option for source density #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #679 +/- ##
==========================================
- Coverage 42.85% 42.80% -0.05%
==========================================
Files 98 98
Lines 9443 9454 +11
==========================================
Hits 4047 4047
- Misses 5396 5407 +11
Continue to review full report at Codecov.
|
karllark
reviewed
Dec 9, 2020
|
sure! can do this morning. |
|
Link test failed due to a timeout - checked manually and this link is fine. Will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #651, I am working on enabling log binning in source density. This involves including an additional source density parameter in the beast_settings file (will update the beast-examples/ files as well), called "sd_binmode" which can be "linear" or "log". I also added raised errors for the linear case if both the number of bins and the bin width are set, and errors for the log case if the number of bins is not set.
Currently, the way it works is to find the min and max source densities in the field, and then use the sd_Nbins (number of bins) parameter to determine logarithmically-spaced bins. The minimum is the first value in the image greater than zero (as the sd image contains a lot of zeros on the edges which aren't actually from the data). Looking forward to thoughts!